-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add telemetry reporting #100
Conversation
6d1fa31
to
d1990a5
Compare
} | ||
|
||
TelemetryLogger.logUsage('signin', telemetryData); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're missing lot of data in telemetryData
here it's only successful yes/no
I would expect the time it has taken, in case of failure, which step succeed/failed.
did we have to restart and how many restart
at which step the user stopped the flow
for example it's different if user aborted if no podman machine was running vs error in doing the task
did we have a PodmanMachineRunning ?
was isSubscriptionManagerInstalled already installed ?
Was it registryAccess part, vmActivation part
for each step, the time it took as well.
Then about the session, probably need some data (about the user being authenticated
I don't know what data we have but maybe number about some fields of the user (counter)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that's fair. We had a meeting on the telemetry issue (#43 (comment)) where these details did not come up. So I guess we under-specified the requirements initially.
Merging the PR and trying to get as far as possible until the deadline is OK for me.
Signed-off-by: Denis Golovin <[email protected]>
d1990a5
to
7e67b53
Compare
Signed-off-by: Denis Golovin <[email protected]>
Signed-off-by: Denis Golovin <[email protected]>
Signed-off-by: Denis Golovin <[email protected]>
It is always one restart if needed at all, I can send start and stop command outcome.
User cannot stop the flow right now, it keeps going until it is finished with failure or success.
I have added error messages to telemetry for registry configuration and subscription activation
Follow up issue #113 created
added field with error message for each part
Follow up issue #114 created
I need clarification for this. What king of tracking we want to do here. Number of logins for specific user? Session duration? |
Fix #43.