Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use Red Hat logo as extension icon #331

Merged

Conversation

dgolovin
Copy link
Collaborator

@dgolovin dgolovin commented Jan 14, 2025

Use Red Hat logo as Developer Sandbox Extension icon on dashboard and resources pages.

image

image

Fix for #278.

@dgolovin dgolovin requested a review from a team as a code owner January 14, 2025 19:15
Copy link
Collaborator

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: should we keep the same height/width of the image ?

@dgolovin
Copy link
Collaborator Author

question: should we keep the same height/width of the image ?

Fixing it. Have to resize icon from http://brand.redhat.com.

@dgolovin dgolovin force-pushed the i278-use-red-hat-logo-for-icon branch from e827d14 to 5948009 Compare January 14, 2025 20:31
@dgolovin
Copy link
Collaborator Author

@benoitf updated icon to have the same size. I updated screenshots in description. You were correct, they definitely look better with 120x120 icon.

@dgolovin dgolovin requested a review from benoitf January 14, 2025 20:32
Copy link
Collaborator

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx for the changes

@dgolovin dgolovin merged commit 0253b49 into redhat-developer:main Jan 14, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants