feat(bulk-import): adding sorting based on column in /imports

[its-mitesh-kumar]

Resolves : https://issues.redhat.com/browse/RHIDP-5295

[rhdh-gh-app]

Changed Packages

Package Name	Package Path	Changeset Bump	Current Version
@red-hat-developer-hub/backstage-plugin-bulk-import-backend	workspaces/bulk-import/plugins/bulk-import-backend	patch	v5.2.1
@red-hat-developer-hub/backstage-plugin-bulk-import	workspaces/bulk-import/plugins/bulk-import	patch	v1.10.7

[christoph-jerolimov]

Hi @its-mitesh-kumar, thanks for picking up also the backend work.

I added some comments, that IMHO we should remove the sorting in our backend, and add sorting params to the request calls for GitHub / Catalog API calls.

Let me know if I miss something and its not possible for some reason. And let the backend team and me know if you want continue with this.

[its-mitesh-kumar]

@christoph-jerolimov @dzemanov I have resolved the comments , Please re-review it

[dzemanov]

Tested with all sort values, on the backend and frontend. Works as expected except for when sortColumn is not specified. Please run prettier to fix failing tests :).

[dzemanov]

Also, please add changeset.

[its-mitesh-kumar]

@dzemanov I have resolved all the comments , CI job failing please try prettier:fix and push it from your system , its not getting resolve from end .

[dzemanov]

@its-mitesh-kumar it is failing on type check in bulkImports.test.ts which needs to be updated.

[its-mitesh-kumar]

@dzemanov Now CI is failing due to prettier issue

[dzemanov]

@its-mitesh-kumar Thank you for all the changes! Enum key repositoryName can be now safely deleted. Tested again with the changes and works fine except for one bug I found, but not sure it it is related to this PR:

2025-01-13.10-40-16.mp4

[its-mitesh-kumar]

@dzemanov ! Quality gate is failing due to its considering the objects of locationUrls as duplicate of each other .

](url)

[dzemanov]

/lgtm
However, @its-mitesh-kumar you will need to request review from CODEOWNERS

[its-mitesh-kumar]

@christoph-jerolimov @debsmita1 can we get this merge ?

[debsmita1]

When I click on a column to change the order, it triggers the API with the current column name and order along with the previous column name and order

Screen.Recording.2025-01-17.at.1.04.27.PM.mov

[its-mitesh-kumar]

@debsmita1 , That's happening due to some odd behavior of useQuery , What I can see if we updating value of any key of queryKey , its recalling queryFunction once with old data and once with new value . We can fix this later , I have raised bug for the same .

[debsmita1]

/lgtm

[debsmita1]

@its-mitesh-kumar Could you resolve this #178 (comment)

[sonarqubecloud]

Quality Gate failed

Failed conditions
13.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Outdated