Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI typo hotfix #182

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

CI typo hotfix #182

wants to merge 1 commit into from

Conversation

kdvalin
Copy link
Member

@kdvalin kdvalin commented Feb 25, 2025

Description

Fixes a typo in the Jira CI container so it can functionally work.

Before/After Comparison

Before

Workflows would skip the login step, preventing the ability to push new releases of the CI image.

After

Workflows will now log in, and have the ability to push new releases of the CI image.

Clerical Stuff

This closes #181

Relates to JIRA: RPOPC-353

@kdvalin kdvalin requested a review from a team February 25, 2025 19:17
Copy link

This relates to RPOPC-353

Copy link
Contributor

@frival frival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do we need to bypass the group review for this?

@kdvalin
Copy link
Member Author

kdvalin commented Feb 25, 2025

This will prevent the container from building and pushing automatically. There might be something in there that can be used, but I don't recall.

If what's in there is non-functional, this blocks efforts for pyperf-wrapper #38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix CI Container workflow
2 participants