Workaround SSLSocket always clearing the buffer #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix: #190 ```ruby buff = "blah".b p io.read_nonblock(10, buffer, exception: false) # :wait_readable p buff ``` The above code when using a regular Ruby IO socket leaves the buffer intact, because it only replaces the content if it actually read something. However when using a `SSLSocket`, the buffer is always cleared regardless of whether something was read or not. This difference could cause the offset to be corrupted by pointing forward.
casperisfine
force-pushed
the
workaround-ssl-socket-buffer-clear
branch
from
1121770
to
98b8944
Compare
casperisfine
force-pushed
the
workaround-ssl-socket-buffer-clear
branch
from
ed9ae98
to
49b0d16
Compare
|
Upstream PR: ruby/openssl#739 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #190
The above code when using a regular Ruby IO socket leaves the buffer intact, because it only replaces the content if it actually read something.
However when using a
SSLSocket, the buffer is always cleared regardless of whether something was read or not.This difference could cause the offset to be corrupted by pointing forward.
NB: not too sure how to regression test this.