Fix SORTABLE argument issue in FT.CREATE command (#3584)

All I know these changes have been enough to pass all redis-om-spring tests in redis/redis-om-spring#357
redis · Oct 15, 2023 · 350d474 · 350d474
1 parent 233ab64
commit 350d474
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 19 deletions.
diff --git a/src/main/java/redis/clients/jedis/search/schemafields/TagField.java b/src/main/java/redis/clients/jedis/search/schemafields/TagField.java
@@ -106,6 +106,14 @@ public void addParams(CommandArguments args) {
       args.add(SEPARATOR).add(separator);
     }
 
+    if (caseSensitive) {
+      args.add(CASESENSITIVE);
+    }
+
+    if (withSuffixTrie) {
+      args.add(WITHSUFFIXTRIE);
+    }
+
     if (sortableUNF) {
       args.add(SORTABLE).add(UNF);
     } else if (sortable) {
@@ -115,13 +123,5 @@ public void addParams(CommandArguments args) {
     if (noIndex) {
       args.add(NOINDEX);
     }
-
-    if (caseSensitive) {
-      args.add(CASESENSITIVE);
-    }
-
-    if (withSuffixTrie) {
-      args.add(WITHSUFFIXTRIE);
-    }
   }
 }
diff --git a/src/main/java/redis/clients/jedis/search/schemafields/TextField.java b/src/main/java/redis/clients/jedis/search/schemafields/TextField.java
@@ -107,29 +107,30 @@ public void addParams(CommandArguments args) {
     args.addParams(fieldName);
     args.add(TEXT);
 
-    if (sortableUNF) {
-      args.add(SORTABLE).add(UNF);
-    } else if (sortable) {
-      args.add(SORTABLE);
+    if (weight != null) {
+      args.add(WEIGHT).add(weight);
     }
 
     if (noStem) {
       args.add(NOSTEM);
     }
-    if (noIndex) {
-      args.add(NOINDEX);
-    }
 
     if (phoneticMatcher != null) {
       args.add(PHONETIC).add(phoneticMatcher);
     }
 
-    if (weight != null) {
-      args.add(WEIGHT).add(weight);
-    }
-
     if (withSuffixTrie) {
       args.add(WITHSUFFIXTRIE);
     }
+
+    if (sortableUNF) {
+      args.add(SORTABLE).add(UNF);
+    } else if (sortable) {
+      args.add(SORTABLE);
+    }
+
+    if (noIndex) {
+      args.add(NOINDEX);
+    }
   }
 }