Skip to content

Commit

Permalink
Apply review comments
Browse files Browse the repository at this point in the history
  - Remove unused configuration
  - [Code clean up] Use endpoint configuration for creating redis version rule
  • Loading branch information
ggivo committed Nov 25, 2024
1 parent a826afb commit 6c58815
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 37 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,10 @@ public abstract class ClientSideCacheTestBase {

@Rule
public RedisVersionRule versionRule = new RedisVersionRule(
HostAndPorts.getRedisEndpoint("standalone1").getHostAndPort(),
HostAndPorts.getRedisEndpoint("standalone1").getClientConfigBuilder().build());
HostAndPorts.getRedisEndpoint("standalone1"));
@Rule
public EnabledOnCommandRule enabledOnCommandRule = new EnabledOnCommandRule(
HostAndPorts.getRedisEndpoint("standalone1").getHostAndPort(),
HostAndPorts.getRedisEndpoint("standalone1").getClientConfigBuilder().build());
HostAndPorts.getRedisEndpoint("standalone1"));

@Before
public void setUp() throws Exception {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,7 @@ public class JedisPooledClientSideCacheTest extends JedisPooledClientSideCacheTe

@ClassRule
public static RedisVersionRule versionRule = new RedisVersionRule(
HostAndPorts.getRedisEndpoint("standalone1").getHostAndPort(),
HostAndPorts.getRedisEndpoint("standalone1").getClientConfigBuilder().build());
HostAndPorts.getRedisEndpoint("standalone1"));

@BeforeClass
public static void prepare() {
Expand Down
11 changes: 0 additions & 11 deletions src/test/resources/Arch/sentinel5/config/node-sentinel5/redis.conf

This file was deleted.

20 changes: 0 additions & 20 deletions src/test/resources/env/endpoint.map

This file was deleted.

0 comments on commit 6c58815

Please sign in to comment.