Apply suggestions from sazzad16

Co-authored-by: M Sazzadul Hoque <[email protected]>
redis · Oct 31, 2023 · 7bb48de · 7bb48de
1 parent 2a46e65
commit 7bb48de
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 13 deletions.
diff --git a/src/main/java/redis/clients/jedis/JedisCluster.java b/src/main/java/redis/clients/jedis/JedisCluster.java
@@ -196,10 +196,10 @@ public JedisCluster(Set<HostAndPort> clusterNodes, JedisClientConfig clientConfi
   }
 
   public JedisCluster(Set<HostAndPort> clusterNodes, JedisClientConfig clientConfig,
-      GenericObjectPoolConfig<Connection> poolConfig, int maxAttempts, Duration maxTotalRetriesDuration,
-      boolean topologyRefreshEnabled, Duration topologyRefreshPeriod) {
-    super(clusterNodes, clientConfig, poolConfig, maxAttempts, maxTotalRetriesDuration, topologyRefreshEnabled,
-        topologyRefreshPeriod);
+      GenericObjectPoolConfig<Connection> poolConfig, boolean topologyRefreshEnabled,
+      Duration topologyRefreshPeriod, int maxAttempts, Duration maxTotalRetriesDuration) {
+    this(new ClusterConnectionProvider(clusterNodes, clientConfig, poolConfig, topologyRefreshEnabled,
+        topologyRefreshPeriod), maxAttempts, maxTotalRetriesDuration);
   }
 
   public JedisCluster(ClusterConnectionProvider provider, int maxAttempts,

diff --git a/src/main/java/redis/clients/jedis/UnifiedJedis.java b/src/main/java/redis/clients/jedis/UnifiedJedis.java
@@ -164,15 +164,6 @@ public UnifiedJedis(Set<HostAndPort> jedisClusterNodes, JedisClientConfig client
     if (proto != null) commandObjects.setProtocol(proto);
   }
 
-  public UnifiedJedis(Set<HostAndPort> jedisClusterNodes, JedisClientConfig clientConfig,
-      GenericObjectPoolConfig<Connection> poolConfig, int maxAttempts, Duration maxTotalRetriesDuration,
-      boolean topologyRefreshEnabled, Duration topologyRefreshPeriod) {
-    this(new ClusterConnectionProvider(jedisClusterNodes, clientConfig, poolConfig, topologyRefreshEnabled,
-        topologyRefreshPeriod), maxAttempts, maxTotalRetriesDuration);
-    RedisProtocol proto = clientConfig.getRedisProtocol();
-    if (proto != null) commandObjects.setProtocol(proto);
-  }
-
   public UnifiedJedis(ClusterConnectionProvider provider, int maxAttempts, Duration maxTotalRetriesDuration) {
     this.provider = provider;
     this.executor = new ClusterCommandExecutor(provider, maxAttempts, maxTotalRetriesDuration);