Use char array for password

redis · Dec 17, 2024 · 8e1152c · 8e1152c
1 parent 9709018
commit 8e1152c
Showing 1 changed file with 4 additions and 8 deletions.
diff --git a/src/main/java/redis/clients/jedis/SslOptions.java b/src/main/java/redis/clients/jedis/SslOptions.java
@@ -239,12 +239,12 @@ public Builder truststore(File truststore) {
          * @param truststorePassword the truststore password. May be empty to omit password and the truststore integrity check.
          * @return {@code this}
          */
-        public Builder truststore(File truststore, String truststorePassword) {
+        public Builder truststore(File truststore, char[] truststorePassword) {
 
             Objects.requireNonNull(truststore, "Truststore must not be null");
             assertFile("Truststore", truststore);
 
-            return truststore(Resource.from(truststore), getPassword(truststorePassword));
+            return truststore(Resource.from(truststore), truststorePassword);
         }
 
         /**
@@ -268,11 +268,11 @@ public Builder truststore(URL truststore) {
          * @param truststorePassword the truststore password. May be empty to omit password and the truststore integrity check.
          * @return {@code this}
          */
-        public Builder truststore(URL truststore, String truststorePassword) {
+        public Builder truststore(URL truststore, char[] truststorePassword) {
 
             Objects.requireNonNull(truststore, "Truststore must not be null");
 
-            return truststore(Resource.from(truststore), getPassword(truststorePassword));
+            return truststore(Resource.from(truststore), truststorePassword);
         }
 
         /**
@@ -386,10 +386,6 @@ public SSLParameters getSslParameters() {
         return sslParameters;
     }
 
-    private static char[] getPassword(String password) {
-        return password != null ? password.toCharArray() : null;
-    }
-
     private static char[] getPassword(char[] chars) {
         return chars != null ? Arrays.copyOf(chars, chars.length) : null;
     }