Add ShardedJedisPoolConfig (#3009)

src/main/java/redis/clients/jedis/ShardedJedisPoolConfig.java

@@ -0,0 +1,13 @@
+package redis.clients.jedis;
+
+import org.apache.commons.pool2.impl.GenericObjectPoolConfig;
+
+public class ShardedJedisPoolConfig extends GenericObjectPoolConfig<ShardedJedis> {
+  public ShardedJedisPoolConfig() {
+    // defaults to make your life with connection pool easier :)
+    setTestWhileIdle(true);
+    setMinEvictableIdleTimeMillis(60000);
+    setTimeBetweenEvictionRunsMillis(30000);
+    setNumTestsPerEvictionRun(-1);
+  }
+}

src/test/java/redis/clients/jedis/tests/ShardedJedisPoolTest.java

@@ -21,6 +21,7 @@
 import redis.clients.jedis.ShardedJedis;
 import redis.clients.jedis.ShardedJedisPipeline;
 import redis.clients.jedis.ShardedJedisPool;
+import redis.clients.jedis.ShardedJedisPoolConfig;
 import redis.clients.jedis.exceptions.JedisExhaustedPoolException;
 import redis.clients.jedis.util.Hashing;
 
@@ -70,8 +71,7 @@ public void checkCloseableConnections() throws Exception {
 
   @Test
   public void checkConnectionWithDefaultPort() {
-    ShardedJedisPool pool = new ShardedJedisPool(new GenericObjectPoolConfig<ShardedJedis>(),
-        shards);
+    ShardedJedisPool pool = new ShardedJedisPool(new ShardedJedisPoolConfig(), shards);
     ShardedJedis jedis = pool.getResource();
     jedis.set("foo", "bar");
     assertEquals("bar", jedis.get("foo"));

src/test/java/redis/clients/jedis/tests/ShardedJedisPoolWithCompleteCredentialsTest.java

@@ -22,7 +22,6 @@
  * This test is only executed when the server/cluster is Redis 6. or more.
  */
 public class ShardedJedisPoolWithCompleteCredentialsTest {
-  private static HostAndPort hnp = HostAndPortUtil.getRedisServers().get(0);
   private static HostAndPort redis1 = HostAndPortUtil.getRedisServers().get(0);
   private static HostAndPort redis2 = HostAndPortUtil.getRedisServers().get(1);
 
@@ -76,8 +75,7 @@ public void checkCloseableConnections() throws Exception {
 
   @Test
   public void checkConnectionWithDefaultPort() {
-    ShardedJedisPool pool = new ShardedJedisPool(new GenericObjectPoolConfig<ShardedJedis>(),
-        shards);
+    ShardedJedisPool pool = new ShardedJedisPool(new ShardedJedisPoolConfig(), shards);
     ShardedJedis jedis = pool.getResource();
     jedis.set("foo", "bar");
     assertEquals("bar", jedis.get("foo"));