Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address further CLIENT SETINFO suffix rules #3536

Merged
merged 2 commits into from
Sep 14, 2023

Conversation

sazzad16
Copy link
Collaborator

Completes and resolves #3535

@sazzad16 sazzad16 added this to the 5.1.0 milestone Sep 14, 2023
@sazzad16 sazzad16 requested a review from chayim September 14, 2023 07:12
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 92.30% and no project coverage change.

Comparison is base (14591c8) 71.24% compared to head (c40d8ab) 71.24%.

❗ Current head c40d8ab differs from pull request most recent head ca1a781. Consider uploading reports for the commit ca1a781 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #3536   +/-   ##
=========================================
  Coverage     71.24%   71.24%           
- Complexity     4775     4779    +4     
=========================================
  Files           279      278    -1     
  Lines         15032    15033    +1     
  Branches       1062     1062           
=========================================
+ Hits          10709    10711    +2     
+ Misses         3857     3854    -3     
- Partials        466      468    +2     
Files Changed Coverage Δ
.../java/redis/clients/jedis/ClientSetInfoConfig.java 91.30% <90.90%> (-8.70%) ⬇️
src/main/java/redis/clients/jedis/Connection.java 80.33% <100.00%> (-0.42%) ⬇️
.../redis/clients/jedis/DefaultJedisClientConfig.java 94.68% <100.00%> (ø)
...in/java/redis/clients/jedis/JedisClientConfig.java 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sazzad16 sazzad16 merged commit bb38c97 into redis:master Sep 14, 2023
4 checks passed
@sazzad16 sazzad16 deleted the libinfo-more branch September 14, 2023 07:37
sazzad16 added a commit that referenced this pull request Sep 14, 2023
* Remove separate interface and class implementation of ClientSetInfoConfig

* Address the braces rule
@sazzad16 sazzad16 modified the milestones: 5.1.0, 5.0.1 Sep 19, 2023
@sazzad16 sazzad16 modified the milestones: 5.0.1, 4.4.x Dec 12, 2023
@sazzad16
Copy link
Collaborator Author

Released on Jedis versions 4.4.5 and 5.0.1

@sazzad16 sazzad16 modified the milestones: 4.4.x, 4.4.5 Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update CLIENT-SETINFO to support suffixes
3 participants