Support INFO command in UnifiedJedis #4078
Conversation
|
|
||
| private static final Object DUMMY_OBJECT = new Object(); | ||
|
|
||
| private final Map<Object, Object> replies; |
There was a problem hiding this comment.
Why not Map<HostAndPort, Object> replies; or NodeID?
There was a problem hiding this comment.
Because we don't a specified solution for this, e.g. in ConnectionProvider and CommandExecutor interfaces, yet. For example, in ConnectionProvider interface the respective method definition is Map<?, ?> getConnectionMap().
| @@ -353,6 +358,16 @@ public String configSet(String parameter, String value) { | |||
| return checkAndBroadcastCommand(commandObjects.configSet(parameter, value)); | |||
| } | |||
|
|
|||
| public final JedisBroadcastReplies info() { | |||
There was a problem hiding this comment.
It will be a bit strange API when connecting to standalone Redis using let's say UnifiedJedis.
Then you will get a JedisBroadcastReplies which makes sense for the cluster.
But in case of standalone, you will get JedisBroadcastReplies, and to get to actual value need to invoke JedisBroadcastReplies::getReplies(with host/port)
or end up with something like
infoReplies.getReplies().values().stream().findFirst().get()
just to get the value
No description provided.