Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix XADD field value name type #1165

Merged
merged 1 commit into from
Oct 17, 2019
Merged

Fix XADD field value name type #1165

merged 1 commit into from
Oct 17, 2019

Conversation

stfnmllr
Copy link
Contributor

@stfnmllr stfnmllr commented Oct 4, 2019

No description provided.

Copy link
Member

@itamarhaber itamarhaber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @d024441

Thanks for the PR - I'm unsure what it is supposed to accomplish. A visual inspection of the present docs appears to be ok. Also, the same syntax is used with, for example, HMSET and appears ok.

@stfnmllr
Copy link
Contributor Author

stfnmllr commented Oct 4, 2019

Hello @itamarhaber

exactly, same syntax is used in HMSET:

{
  "name": ["field", "value"],
  "type": ["string", "string"],
   "multiple": true
} 

but in XADD value and string are in the 'wrong' array:

{
  "name": ["field", "string"],
  "type": ["value", "string"],
  "multiple": true
}

which leads to the following rendered help text in XADD:
XADD key ID field string [field string ...]
which should read
XADD key ID field value [field value ...]

Please be also noticed that the 'Capped streams' option of XADD is completely missing in command.json for XADD.

Best regards

@itamarhaber
Copy link
Member

Ok, I see now. Good.

Please be also noticed that the 'Capped streams' option of XADD is completely missing in command.json for XADD.

Thanks for noticing, tracking this at redis/redis-io#167. The problem is that the syntax makes it impossible to express it (i.e. nested optionals).

@itamarhaber itamarhaber merged commit 6605fec into redis:master Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants