Allow by/get of sort(ro) in cluster mode. #2611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for redis-doc pending review.Visit the deploys page to approve it
|
oranagra
reviewed
Nov 29, 2023
commands/sort.md
Outdated
| @@ -105,8 +105,7 @@ SORT mylist BY weight_* GET object_* GET # | |||
|
|
|||
| ## Restrictions for using external keys | |||
|
|
|||
| When enabling `Redis cluster-mode` there is no way to guarantee the existence of the external keys on the node which the command is processed on. | |||
| In this case, any use of `GET` or `BY` which reference external key pattern will cause the command to fail with an error. | |||
| Specially, in `Redis cluster-mode`, `BY` or `GET` can only be used when pattern contains hash tag and implies a specific slot which the key is also in, which means any key matching this pattern must be in the same slot as the key, and therefore in the same node. For example, in cluster mode, `{mylist}weight_*` is acceptable as a pattern when sorting `mylist`, while pattern `{abc}weight_*` will be denied, causing the command to fail with an error. | |||
There was a problem hiding this comment.
LGTM, but i think we're missing a word about older version (mention that before 8.0, this was disallowed)
oranagra
added
waiting-for-upstream
CharlesChen888
force-pushed
the
sort-byget-hashtag
branch
from
1ce5338 to
694b973
Compare
oranagra
approved these changes
Nov 30, 2023
soloestoy
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doc of redis/redis#12728.