Skip to content

Commit

Permalink
refactor(message.go): remove RedisResult.IsMap, RedisResult.IsArray
Browse files Browse the repository at this point in the history
  • Loading branch information
unknowntpo committed Nov 25, 2024
1 parent a8eb47c commit afb8492
Show file tree
Hide file tree
Showing 2 changed files with 39 additions and 20 deletions.
2 changes: 0 additions & 2 deletions rueidiscompat/adapter.go
Original file line number Diff line number Diff line change
Expand Up @@ -5355,7 +5355,6 @@ func (c *Compat) FTExplainWithArgs(ctx context.Context, index string, query stri
// see go-redis v9.7.0 https://github.com/redis/go-redis/blob/v9.7.0/search_commands.go#L1393
func (c *Compat) FTInfo(ctx context.Context, index string) *FTInfoCmd {
cmd := c.client.B().FtInfo().Index(index).Build()
fmt.Println(cmd.Commands())
return newFTInfoCmd(c.client.Do(ctx, cmd))
}

Expand Down Expand Up @@ -5566,7 +5565,6 @@ func (c *Compat) FTSearchWithArgs(ctx context.Context, index string, query strin
}
}
cmd := cmds.FtSearchQuery(_cmd).Build()
fmt.Print(cmd.Commands())
return newFTSearchCmd(c.client.Do(ctx, cmd), options)
}

Expand Down
57 changes: 39 additions & 18 deletions rueidiscompat/command.go
Original file line number Diff line number Diff line change
Expand Up @@ -3482,11 +3482,16 @@ func (cmd *AggregateCmd) from(res rueidis.RedisResult) {
return
}
cmd.SetRawVal(anyRes)
if !(res.IsMap() || res.IsArray()) {
msg, err := res.ToMessage()
if err != nil {
cmd.SetErr(err)
return
}
if !(msg.IsMap() || msg.IsArray()) {
panic("res should be either map(RESP3) or array(RESP2)")
}
if res.IsMap() {
total, docs, err := res.AsFtAggregate()
if msg.IsMap() {
total, docs, err := msg.AsFtAggregate()
if err != nil {
cmd.SetErr(err)
return
Expand All @@ -3503,7 +3508,7 @@ func (cmd *AggregateCmd) from(res rueidis.RedisResult) {
return
}
// is RESP2 array
rows, err := res.ToArray()
rows, err := msg.ToArray()
if err != nil {
cmd.SetErr(err)
return
Expand Down Expand Up @@ -4095,16 +4100,22 @@ func (cmd *FTSpellCheckCmd) from(res rueidis.RedisResult) {
cmd.SetErr(err)
return
}
if !(res.IsMap() || res.IsArray()) {
msg, err := res.ToMessage()
if err != nil {
cmd.SetErr(err)
return
}
if !(msg.IsMap() || msg.IsArray()) {
panic("res should be either map(RESP3) or array(RESP2)")
}
if res.IsMap() {
if msg.IsMap() {
// is RESP3 map
m, err := res.ToMap()
m, err := msg.ToMap()
if err != nil {
cmd.SetErr(err)
return
}
anyM, err := res.ToAny()
anyM, err := msg.ToAny()
if err != nil {
cmd.SetErr(err)
return
Expand Down Expand Up @@ -4147,12 +4158,12 @@ func (cmd *FTSpellCheckCmd) from(res rueidis.RedisResult) {
return
}
// is RESP2 array
arr, err := res.ToArray()
arr, err := msg.ToArray()
if err != nil {
cmd.SetErr(err)
return
}
anyRes, err := res.ToAny()
anyRes, err := msg.ToAny()
if err != nil {
cmd.SetErr(err)
return
Expand Down Expand Up @@ -4294,12 +4305,17 @@ func (cmd *FTSearchCmd) from(res rueidis.RedisResult) {
return
}
cmd.SetRawVal(anyRes)
if !(res.IsMap() || res.IsArray()) {
msg, err := res.ToMessage()
if err != nil {
cmd.SetErr(err)
return
}
if !(msg.IsMap() || msg.IsArray()) {
panic("res should be either map(RESP3) or array(RESP2)")
}
if res.IsMap() {
if msg.IsMap() {
// is RESP3 map
m, err := res.ToMap()
m, err := msg.ToMap()
if err != nil {
cmd.SetErr(err)
return
Expand Down Expand Up @@ -4381,7 +4397,7 @@ func (cmd *FTSearchCmd) from(res rueidis.RedisResult) {
return
}
// is RESP2 array
data, err := res.ToArray()
data, err := msg.ToArray()
if err != nil {
cmd.SetErr(err)
return
Expand Down Expand Up @@ -4499,12 +4515,17 @@ func (cmd *FTSynDumpCmd) from(res rueidis.RedisResult) {
return
}
cmd.SetRawVal(anyRes)
if !(res.IsMap() || res.IsArray()) {
msg, err := res.ToMessage()
if err != nil {
cmd.SetErr(err)
return
}
if !(msg.IsMap() || msg.IsArray()) {
panic("res should be either map(RESP3) or array(RESP2)")
}
if res.IsMap() {
if msg.IsMap() {
// is RESP3 map
m, err := res.ToMap()
m, err := msg.ToMap()
if err != nil {
cmd.SetErr(err)
return
Expand All @@ -4522,7 +4543,7 @@ func (cmd *FTSynDumpCmd) from(res rueidis.RedisResult) {
return
}
// is RESP2 array
arr, err := res.ToArray()
arr, err := msg.ToArray()
if err != nil {
cmd.SetErr(err)
return
Expand Down

0 comments on commit afb8492

Please sign in to comment.