Fix connectors null command #376
Conversation
Copy the same solution as it was introduced in `TestGoHelmEquivalence` test case. Reference redpanda-data/helm-charts@c84b13a
RafalKorepta
force-pushed
the
rk/k8s-475/fix-connectors-command
branch
from
f06a531 to
cfc5742
Compare
When sasl authorization is disabled the connectors container command is set to null which causes whole startup to fail due to the fact that `./launch.sh` bash script configures all properties of connectors by default.
RafalKorepta
force-pushed
the
rk/k8s-475/fix-connectors-command
branch
from
cfc5742 to
b8c1c23
Compare
| @@ -182,6 +181,12 @@ func Deployment(dot *helmette.Dot) *appsv1.Deployment { | |||
| }, | |||
| }, | |||
| } | |||
|
|
|||
| if !helmette.Empty(values.Deployment.Command) { | |||
There was a problem hiding this comment.
This fix doesn't make sense to me.
Command []string `json:"command,omitempty" protobuf:"bytes,3,rep,name=command"`From the golang (Kubernetes) perspective, not setting Command and explicitly setting Command to nil are equivalent. Is there something I'm overlooking?
There was a problem hiding this comment.
transpiled template code is always setting command regardless of the command.
Go code will work. Template not. You can see the diff in the golden file.
| - command: null | ||
| env: | ||
| - env: |
There was a problem hiding this comment.
👍 on the fix @RafalKorepta
@chrisseto here's a part of the diff to which Rafal is referring to.
There was a problem hiding this comment.
Right but when the K8s API JSON unmarshals (You've read sig YAML, it's just JSON)command: null into a Container struct, there is no distinction between Command not being specified and being explicit set to null/nil. The behavior is present for many other fields that show up as null (e.g. creationTimestamp).
Screen.Recording.2025-01-09.at.10.20.11.mov
There was a problem hiding this comment.
Ok, then I will dig further why connectors does not work
dd34b33
Run test against unreleased version of Redpanda subcharts
Copy the same solution as it was introduced in
TestGoHelmEquivalencetest case.Reference
redpanda-data/helm-charts@c84b13a
f06a531
Do not pass empty command into connectors container
When sasl authorization is disabled the connectors container command is set to
null which causes whole startup to fail due to the fact that
./launch.shbashscript configures all properties of connectors by default.
K8S-475