Fix redpanda-operator release piepeline #469
Merged
+11
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RafalKorepta
requested review from
chrisseto,
andrewstucki and
gene-redpanda
as code owners
chrisseto
reviewed
Mar 3, 2025
.buildkite/pipeline.yml
Outdated
| // 3. NIGHTLY_RELEASE envvar isn't set (paranoid check) | ||
| // 4. This isn't a pull request (paranoid check) | ||
| (build.tag =~ /^v/ || build.tag =~ /^operator\/v/) && | ||
| (build.branch == "main" || build.branch =~ /^release\//) && | ||
| (build.branch == "main" || build.branch =~ /^release\// || build.branch =~ /^v/ || build.branch =~ /^operator\/v/) && |
There was a problem hiding this comment.
Can we remove the checks on main and release/ as we know they'll never be relevant? We could alternatively remove all branch level checks as they're synonymous with tag and specifying both may be misleading.
There was a problem hiding this comment.
Agree removed branch check
.buildkite/pipeline.yml
Outdated
| @@ -81,11 +81,11 @@ steps: | |||
| if: | | |||
| // Only run if: | |||
| // 1. There's a tag and it's of the form 'v*' or 'operator/v*' | |||
| // 2. Source branch is main or release/* | |||
| // 2. Source branch is main or release/* (during release the branch will be equal to tag name) | |||
There was a problem hiding this comment.
Can you add the URL from the PR description to this comment. If we remove the branch checks, let's preserve the comment about branch == tag so no one forgets and tries to add it back in later :)
RafalKorepta
force-pushed
the
rk/fix-official-release-process
branch
from
dd277da to
98a42c9
Compare
RafalKorepta
force-pushed
the
rk/fix-official-release-process
branch
from
98a42c9 to
abc198e
Compare
When redpanda-operator github repository recieves new tag it triggers buildkite build. As the following statement from buildkite community forum the branch has the same value as tag. ``` Due to how tags work in git, a branch is not easily inferred, nor is it required to check out a tag. For this reason we’re setting BUILDKITE_BRANCH and BUILDKITE_TAG to the same value. This is the intended behaviour. Our docs aren’t really clear on this and we’re updating them now. ``` Reference https://forum.buildkite.community/t/branch-names-vs-tag-names/974/2
RafalKorepta
force-pushed
the
rk/fix-official-release-process
branch
from
abc198e to
d908b6a
Compare
chrisseto
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When redpanda-operator github repository recieves new tag it triggers buildkite build. As the following statement from buildkite community forum the branch has the same value as tag.
Reference
https://forum.buildkite.community/t/branch-names-vs-tag-names/974/2