Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a local FastBoot setup #15

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add a local FastBoot setup #15

wants to merge 1 commit into from

Conversation

Windvis
Copy link
Member

@Windvis Windvis commented Feb 14, 2024

This makes it easier to test the dummy app against a specific environment without having to deal with local untracked code changes.

A .env file can be created (starting from the .env.example file) to configure the needed env variables.

The start:env script can then be used to start the test app.

This makes it easier to test the dummy app against a specific environment without having to deal with local untracked code changes.

A .env file can be created (starting from the .env.example file) to configure the needed env variables.

The `start:env` script can then be used to start the test app.
@@ -25,6 +25,8 @@
"lint:js:fix": "eslint . --fix",
"release": "release-it",
"start": "ember serve",
"start:env": "dotenvx run -- npm run start:proxy",
Copy link
Member Author

@Windvis Windvis Feb 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks a bit strange, but without a second script the env variables aren't yet available to pass into the arguments for ember serve, and we want to reuse the METIS_BACKEND_URL for the proxy value.

Alternatively we could do something like this: dotenvx run -- bash -c 'ember serve --proxy $VAR' but that won't work in environments without bash, so I think this version is safer.

Maybe it should be renamed to make it clear that it's intended to be used by the other script. _env-proxy?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant