Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Modifier Particle Rendering #412

Merged
merged 1 commit into from
Nov 24, 2024
Merged

Fix Modifier Particle Rendering #412

merged 1 commit into from
Nov 24, 2024

Conversation

Batfoxkid
Copy link
Member

  • Fixes the incorrect SetTransmit function
  • Made the particle always transmit to players on spawn for 0.2 seconds (to make it properly render)
  • Cloak and disguise conditions remove/readd particle effects

FortyTwoFortyTwo
FortyTwoFortyTwo approved these changes Nov 19, 2024
View reviewed changes
addons/sourcemod/scripting/saxtonhale.sp
@@ -1159,11 +1159,18 @@ public void TF2_OnConditionAdded(int iClient, TFCond nCond)
if (SaxtonHale_IsValidBoss(iClient))
{
SaxtonHaleBase(iClient).CallFunction("OnConditionAdded", nCond);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why milked code is here when it could've been in base_boss and making use of this call along with particles removed, same to conds removed.

I'll still merge it regardless if this is changed or not.

@FortyTwoFortyTwo FortyTwoFortyTwo merged commit 2d3f490 into redsunservers:master Nov 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FortyTwoFortyTwo FortyTwoFortyTwo FortyTwoFortyTwo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Batfoxkid @FortyTwoFortyTwo