Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] react-json-tree: Handle sparse empty arrays greater than limit #1828

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

arcataroger
Copy link

@arcataroger arcataroger commented Feb 7, 2025

Potentially fixes #1827

Given an input like:

let sparseArrayBroken = [];
sparseArrayBroken[50] = "this will cause a crash";
<JSONTree data={sparseArrayBroken}/>

Currently getCollectionEntries() and its isRange() call does not properly handle sparse arrays greater than the limit. It will try to pass through empty entries to the isRange() and subsequent const { key, value } = entry destructuring, both of which halt the script.

This PR bypasses the crash and allows the rendering to continue.

There is a separate cosmetic bug that this PR does NOT fix:

  • If limitedEntries in getCollectionEntries() is not subset, but limit - 4 === length - 5, it will cause a single-item collapsed range
  • And if the item(s) in that single-item range are empty, expanding that range will just cause it to disappear:
    Screenshot 001019
  • Probably it doesn't need to be range-ified at all in that case, but that's outside the scope of this PR

Copy link

changeset-bot bot commented Feb 7, 2025

⚠️ No Changeset found

Latest commit: 8084678

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

react-json-tree crashes on sparse array with 51+ elements
1 participant