[Fix] react-json-tree: Handle sparse empty arrays greater than limit #1828
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potentially fixes #1827
Given an input like:
Currently
getCollectionEntries()
and itsisRange()
call does not properly handle sparse arrays greater than thelimit
. It will try to pass through empty entries to theisRange()
and subsequentconst { key, value } = entry
destructuring, both of which halt the script.This PR bypasses the crash and allows the rendering to continue.
There is a separate cosmetic bug that this PR does NOT fix:
limitedEntries
in getCollectionEntries() is not subset, butlimit - 4
===length - 5
, it will cause a single-item collapsed range