Add basic c-node and supporting services #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abelino
force-pushed
the
setup-cnode-comms
branch
2 times, most recently
from
7d2b8c9 to
ad175d4
Compare
amclain
requested changes
Sep 2, 2024
| end | ||
|
|
||
| @doc false | ||
| defdelegate ei_log(level, term), to: Logger, as: :log |
There was a problem hiding this comment.
⛔ (required)
The second arg is the log message as a string, right?
Suggested change
| defdelegate ei_log(level, term), to: Logger, as: :log | |
| defdelegate ei_log(level, message), to: Logger, as: :log |
There was a problem hiding this comment.
It currently is returning a string, but nothing stopping us from this being able to return a term, i.e. structured data.
abelino
force-pushed
the
setup-cnode-comms
branch
4 times, most recently
from
5dde4ca to
57f4e66
Compare
abelino
force-pushed
the
setup-cnode-comms
branch
from
57f4e66 to
f165188
Compare
amclain
approved these changes
Sep 3, 2024
abelino
force-pushed
the
setup-cnode-comms
branch
from
f165188 to
fcbd082
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE:
iex --sname app -S mixBACNet.add_device(nil)is there to illustrate how a:gen.callworks between an Elixir process and C-Node process. It returns{:error, :unimplemented}for now.