-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add strict option #9
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updates to the readme are missing 😉
@@ -15,7 +15,6 @@ defmodule Speck.MixProject do | |||
deps: deps(), | |||
docs: docs(), | |||
dialyzer: [ | |||
ignore_warnings: "dialyzer.ignore.exs", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⛔ (required)
Why was this removed? It's an important project file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The file wasn't removed but renamed to .dialyzer_ignore.exs
which is the default name dialyxir
looks for in a project. The way some of the source code is written in dialyxir
also suggests usage of ignore_warnings
is considered legacy. There is a bug in dialyxir
right now which flat out ignores the ignore_warnings
opt and so even w/ ignore_warnings
defined it'll still look for .dialyzer_ignore.exs
hence the rename.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pinned the version to 1.4.3
avoiding the issue entirely.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Hm, I wonder if .dialyzer_ignore.exs
became a thing after I created the design pattern around the other file. Since that's what their docs say to use, that's a good reason for us to switch over to doing it that way. Our project template will also need to be updated.
5e9d103
to
ba35141
Compare
ba35141
to
956c9f5
Compare
bf1d525
to
487883c
Compare
Referencing #8
Adds ability to add the
strict
option locally to a struct's attribute or globally, applying to an entire struct.