Skip to content

Commit

Permalink
Revert "Preserve es modules in babel config (slab#4013)"
Browse files Browse the repository at this point in the history
This reverts commit 5fa786c.

Upstream merged a change that ships ESM directly, with no transformation
through babel, and without marking the library as `"type": "module"`

This breaks some of our Node.js tests, which (correctly) complain that
Quill shouldn't be using `import` statements without declaring itself as
an ESM library with `"type": "module"`.

This change just reverts the break.
  • Loading branch information
alecgibson committed Mar 11, 2024
1 parent ee90407 commit 01e17c2
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 6 deletions.
1 change: 0 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
- Fix toolbar button state not updated in some cases
- Narrower `BubbleTheme.tooltip` type
- Fix `Selection.getBounds()` when starting range at end of text node
- Improve compatibility with esbuild

# 2.0.0-rc.1

Expand Down
5 changes: 1 addition & 4 deletions packages/quill/babel.config.js
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
const pkg = require('./package.json');

module.exports = {
presets: [
['@babel/preset-env', { modules: false }],
'@babel/preset-typescript'
],
presets: ['@babel/preset-env', '@babel/preset-typescript'],
plugins: [
['transform-define', { QUILL_VERSION: pkg.version }],
'./scripts/babel-svg-inline-import',
Expand Down
2 changes: 1 addition & 1 deletion packages/quill/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@reedsy/quill",
"version": "2.0.0-reedsy-5.0.1",
"version": "2.0.0-reedsy-5.0.2",
"description": "Your powerful, rich text editor",
"author": "Jason Chen <[email protected]>",
"homepage": "https://quilljs.com",
Expand Down

0 comments on commit 01e17c2

Please sign in to comment.