TERM and fish test

b2/_internal/_cli/autocomplete_install.py

@@ -193,22 +193,25 @@ def is_enabled(self) -> bool:
         That alone cannot be used, since fish tends to always propose completions (e.g. suggesting similarly
         named filenames).
         """
+        environ = os.environ.copy()
+        environ.setdefault("TERM", "xterm")  # TERM has to be set for fish to load completions
         return _silent_success_run(
             [
                 self.shell_exec, '-i', '-c',
                 f'string length -q -- (complete -C{quote(f"{self.prog} ")} >/dev/null && complete -c {quote(self.prog)})'
-            ]
+            ],
+            env=environ,
         )
 
 
-def _silent_success_run(cmd: list[str], timeout: int | None = 60) -> bool:
-    # start_new_session prevents `zsh -i` interaction with parent terminal under pytest-xdist
+def _silent_success_run(cmd: list[str], timeout: int | None = 60, env: dict | None = None) -> bool:
     p = subprocess.Popen(
         cmd,
         stdout=subprocess.PIPE,
         stderr=subprocess.PIPE,
         stdin=subprocess.DEVNULL,
-        start_new_session=True,
+        start_new_session=True,  # prevents `zsh -i` messing with parent tty under pytest-xdist
+        env=env,
     )
 
     try:

test/unit/conftest.py

@@ -53,6 +53,8 @@ def env(homedir, monkeypatch):
     """Get ENV for running b2 command from shell level."""
     monkeypatch.setenv("HOME", str(homedir))
     monkeypatch.setenv("SHELL", "/bin/bash")  # fix for running under github actions
+    if "TERM" not in os.environ:
+        monkeypatch.setenv("TERM", "xterm")
     yield os.environ
 
 

test/unit/console_tool/test_install_autocomplete.py

@@ -37,9 +37,6 @@ def test_install_autocomplete(b2_cli, env, shell, monkeypatch):
         expected_part_of_stdout=f"Autocomplete successfully installed for {shell}",
     )
 
-    if shell == "fish":  # no idea how to test fish autocompletion (does not seem to work with dummy terminal)
-        return
-
     with pexpect_shell(shell_bin, env=env) as pshell:
         pshell.send("b2 \t\t")
         pshell.expect_exact(["authorize-account", "download-file", "get-bucket"], timeout=30)