B2-64 Throw error in CLI on passing special headers as file info #245
Conversation
In cli v4 passing `--info b2-content-disposition=attachment` will result in an error telling the user to use `--content-disposition` etc.
Add --allow-special-info flag to disable validation of special headers passed to --info
b2/_internal/console_tool.py
Outdated
| error_msg = "Use --{} flag instead of passing {} to --info".format( | ||
| key.lstrip('b2-'), key | ||
| ) |
There was a problem hiding this comment.
Is there any particular reason why you're preferring .format() over f-string in this instance?
This is not a request for change, just curious.
There was a problem hiding this comment.
Calling functions/methods inside a f-string feels weird to me. And the linter was complaining about %-formatting for some reason. I'll recheck anyways.
b2/_internal/b2v3/registry.py
Outdated
|
|
||
| class CopyFileById(CopyFileByIdV4): | ||
| __doc__ = CopyFileByIdV4.__doc__ | ||
| WARN_SPECIAL_FILE_INFO_HEADERS = True |
There was a problem hiding this comment.
I'd prefer something like ERROR_ON_HEADERS_AS_FILE_INFO = False (not necessarily this exact naming) because WARN_SPECIAL_FILE_INFO_HEADERS might make it sound like in case of False, there's just gonna be no warning, it's an allowed behavior. Whereas what happens is a stronger limitation - an error.
|
Just to double-check - while this looks good to me, this PR is not intended to be merged until changes in the SDK (or here?) adds |
Renamed `WARN_SPECIAL_FILE_INFO_HEADERS` -> `ERROR_ON_HEADERS_AS_FILE_INFO` and flipped the meaning
From `--allow-special-info` to `--allow-headers-in-info`
No description provided.