Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

authorize-account output account info json #246

Merged
merged 1 commit into from
Jan 23, 2024
Merged

authorize-account output account info json #246

merged 1 commit into from
Jan 23, 2024

Conversation

emnoor-reef
Copy link

No description provided.

@emnoor-reef emnoor-reef marked this pull request as ready for review January 23, 2024 08:55
@@ -1104,6 +1133,9 @@ def authorize(self, application_key_id, application_key, realm: str | None):
)
self.api.account_info.clear()
return 1
if print_success_json:
data = format_account_info(self.api.account_info)
self._print_json(data)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imo it doesn't make any sense to have authorize method call format_account_info method if argument was specified

Instead just call format_account_info&print when you need it; i.e in AuthorizeAccount.run .
It will be simpler, less code while providing the same functionality.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved the call from authorize() to _run().

@emnoor-reef emnoor-reef merged commit 9f197ce into reef-technologies:master Jan 23, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants