improve cmd deprecation warning by support nested replaced_by_cmd #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjurbanski-reef
commented
Apr 25, 2024
b2/_internal/console_tool.py
Outdated
| @@ -1121,12 +1121,12 @@ def __str__(self): | |||
|
|
|||
| class CmdReplacedByMixin: | |||
| deprecated = True | |||
| replaced_by_cmd: type[Command] | |||
| replaced_by_cmd: type[Command] | tuple[type[Command], ...] | |||
|
|
|||
| def run(self, args): | |||
| self._print_stderr( | |||
| f'WARNING: {self.__class__.name_and_alias()[0]} command is deprecated. ' | |||
There was a problem hiding this comment.
I do realize I dont handle the case of replacing nested command, only BY nested commands... but I don't think it matters much right now and alternative would require figuring out the registry, building path from that etc.
Worst case scenario we use this solution for this release, and rewrite these few lines of code in the next one IF need arises.
mjurbanski-reef
force-pushed
the
nested_replaced_by_cmd
branch
from
467eba1 to
589d49a
Compare
mjurbanski-reef
force-pushed
the
nested_replaced_by_cmd
branch
from
589d49a to
1c00f90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.