RT-258 Add Prometheus Metrics exports #5
Conversation
We're exporting metrics to a customizable (through env vars) directory in the Prometheus .prom format. We have a default metric that states the last scan and push that occurred. Apart from it, there is already groundwork for making new metrics on the fly should we need to.
There was a problem hiding this comment.
The solution looks good. But IMO it is unnecessarily abstracted. A simple function that takes a path and a value (timestamp) and writes to the prom file would have been much better.
Unless there are other metrics planned to be exported, I don't see the value of abstraction from the get go.
- removed metric class, as it was holding a single value - switched to pathlib in exporter check_dir - removed redundant file deletion call with shutil
I agree in retrospect. I still kept some abstractions though, I believe this can benefit from it as more metrics are added should the demand arise. Still, I deleted the Metric class, since it was essentially holding a single value haha. |
- removed redudant dict argument to metric exporter - switched to pathlib on more instances - added metric exporter test
|
made the requested changes (or I hope) also pushed from wrong account sorry |
| from vulnrelay.metrics.metric import MetricNames | ||
|
|
||
|
|
||
| def test_export_metrics(): |
There was a problem hiding this comment.
This doesn't test much without actually verifying the output file contents
Intent:
This is part of RT-258. The other part will soon be another pull request to the Django Template.
Summary of changes:
We're exporting metrics to a customizable (through env vars) directory in the Prometheus .prom format. We have a default metric that states the last scan and push that occurred. Apart from it, there is already groundwork for making new metrics on the fly should we need to.