Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few UI/UX tweaks to the coaching session page #27

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

jhodapp
Copy link
Member

@jhodapp jhodapp commented Aug 17, 2024

Description

This PR makes a few UI tweaks to prepare the page layout for adding the main missing elements like agreements, actions, etc.

GitHub Issue: None

Changes

  • Fix the overarching goal div alignment to always line up with the coaching notes div on the left and right sides
  • Ensure the coaching session title div stays aligned with coaching notes on left and right sides as the window size changes
  • Remove the CodeViewer and PresetShare components from the coaching session page

Screenshots / Videos Showing UI Changes (if applicable)

Screenshot 2024-08-20 at 21 54 04

Testing Strategy

  1. Navigate to the coaching sessions page
  2. Change the window size from very wide to very narrow and notice the above alignment tweaks hold true

Concerns

None

@jhodapp jhodapp self-assigned this Aug 17, 2024
@jhodapp jhodapp added the enhancement Improves existing functionality or feature label Aug 17, 2024
@jhodapp jhodapp changed the title Fix the overarching goal div alignment Several UI/UX tweaks to the coaching session page Aug 20, 2024
@jhodapp jhodapp marked this pull request as ready for review August 21, 2024 02:56
@jhodapp jhodapp requested review from calebbourg and qafui August 21, 2024 02:56
@jhodapp jhodapp changed the title Several UI/UX tweaks to the coaching session page A few UI/UX tweaks to the coaching session page Aug 21, 2024
Copy link
Collaborator

@qafui qafui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍🏾

@jhodapp jhodapp merged commit 3f9c6f6 into main Aug 22, 2024
1 check passed
@jhodapp jhodapp deleted the new_coaching_page_ui_tweaks branch August 22, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves existing functionality or feature
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants