-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more advanced text editor for coaching notes #44
Merged
jhodapp
merged 14 commits into
main
from
42-feature-request-suggestion-integrate-a-more-advanced-text-editor-for-coaching-notes
Oct 18, 2024
Merged
Add more advanced text editor for coaching notes #44
jhodapp
merged 14 commits into
main
from
42-feature-request-suggestion-integrate-a-more-advanced-text-editor-for-coaching-notes
Oct 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…style doesn't work correctly yet for this)
jhodapp
added
enhancement
Improves existing functionality or feature
feature work
Specifically implementing a new feature
labels
Oct 15, 2024
…for chosen language. Also enable use of tailwindcss tags and classes in scss files.
…ng to explicitly list all extensions used.
jhodapp
commented
Oct 18, 2024
Remove commented out line.
calebbourg
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to test that, from what I can tell, all existing features are working!
jhodapp
deleted the
42-feature-request-suggestion-integrate-a-more-advanced-text-editor-for-coaching-notes
branch
October 18, 2024 19:11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
Improves existing functionality or feature
feature work
Specifically implementing a new feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new CoachingNotes and TipTapEditor pair of components to bring rich text editing into a coaching session.
GitHub Issue: #42
Changes
TipTapEditor
component which wraps the TipTap rich text editorCoachingNotes
into a separate file and out of coaching session page.tsxScreenshots / Videos Showing UI Changes
Testing Strategy
Concerns
None