Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All environment variables for the dockerized application are set by the backend #53

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

jhodapp
Copy link
Member

@jhodapp jhodapp commented Dec 15, 2024

Description

This PR now ensures that all environment variables for the dockerized version of this application are set and passed from the backend/docker-compose.yaml.

GitHub Issue: None

Changes

  • All environment variables for the dockerized application are set and passed from the backend/docker-compose.yaml

Screenshots / Videos Showing UI Changes (if applicable)

Testing Strategy

  1. Build the entire dockerized application from the backend
  2. Ensure that the app functions as expected if you change environment variables in the backend's .env file

Concerns

None

@jhodapp jhodapp added the enhancement Improves existing functionality or feature label Dec 15, 2024
@jhodapp jhodapp self-assigned this Dec 15, 2024
# NEXT_PUBLIC_BACKEND_SERVICE_PROTOCOL="http"
# NEXT_PUBLIC_BACKEND_SERVICE_PORT=4000
# NEXT_PUBLIC_BACKEND_SERVICE_HOST="localhost"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming these are meant to be commented out as a default?

@jhodapp jhodapp merged commit 79646ad into main Dec 16, 2024
1 check passed
@jhodapp jhodapp deleted the pass_env_from_backend_for_container_build branch December 16, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improves existing functionality or feature
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants