Skip to content

Commit

Permalink
Reintorduce 3.6 test but run-on ubuntu-20.04
Browse files Browse the repository at this point in the history
  • Loading branch information
@aglavic
aglavic committed Feb 22, 2023
1 parent 2f2d219 commit efd3abb
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/pytest.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,10 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

backport:
runs-on: ubuntu-latest
runs-on: ubuntu-20.04
strategy:
matrix:
python-version: [3.7]
python-version: [3.6, 3.7]

steps:
- uses: actions/checkout@v3
Expand Down

3 comments on commit efd3abb

@bmaranville
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a pressing need for 3.6? It is not receiving even security updates anymore.

@aglavic
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there are a lot of systems in facilities running long outdated library versions, SINQ instuments included. (Our cluster has python 3.4, for example.)
I don't think python security updates are a big concern for systems not used in webservers and/or within confined networks. So as long as the effort is limited I'd keep it compatible.

Last time I looked (January) 3.11 didn't have many relevant libraries available, so I would see compatibility with 3.11 as less important then 3.6.

@bmaranville
Copy link
Contributor

@bmaranville bmaranville commented on efd3abb Feb 23, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point - there are many ancient machines running instruments around the world, though virtual environments/conda make it a lot easier to work with more modern python versions wherever you are, and without requiring superuser privileges.

Please sign in to comment.