Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with cert generation #259

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Fix issues with cert generation #259

merged 1 commit into from
Nov 7, 2023

Conversation

mingyech
Copy link
Member

@mingyech mingyech commented Nov 6, 2023

  • Add salt when creating hkdf rand reader from conjure seed
  • Uncomment server cert so that client and server certs are different
  • Use crypto/rand.Reader instead of reader from conjure seed for signing since signature does not have to be the same

@mingyech mingyech requested a review from jmwample November 6, 2023 05:34
@jmwample jmwample merged commit 4026944 into master Nov 7, 2023
10 checks passed
@jmwample jmwample deleted the cert branch November 7, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants