Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: WATM v1 #6

Merged
merged 2 commits into from
Apr 8, 2024
Merged

new: WATM v1 #6

merged 2 commits into from
Apr 8, 2024

Conversation

gaukas
Copy link
Contributor

@gaukas gaukas commented Apr 5, 2024

v1: based on v0, we renamed and redesigned tons of interfaces, introduced new working modes, and fixed potential bugs.

v1: based on v0, we renamed and redesigned tons of interfaces, introduced new working modes, and fixed potential bugs.

Signed-off-by: Gaukas Wang <[email protected]>
@gaukas
Copy link
Contributor Author

gaukas commented Apr 5, 2024

wasm-ld: error: /tmp/tinygo2876025176/main.o: undefined symbol: runtime.getAuxv
failed to run tool: wasm-ld
error: failed to link /tmp/tinygo2876025176/main: exit status 1
Error: Process completed with exit code 1.

Weird. Theoretically this shouldn't happen with cpu package properly replaced.

Trying to reproduce locally. Maybe something is missing?

@gaukas
Copy link
Contributor Author

gaukas commented Apr 5, 2024

I see, we are (indirectly) using v0.19.0, but the replace directive replaces only v0.16.0.

@gaukas gaukas self-assigned this Apr 5, 2024
Move tinygo/v?/examples/replace/x/sys` to `tinygo/replaced/golang.org/x/[email protected]`

Signed-off-by: Gaukas Wang <[email protected]>
@gaukas gaukas marked this pull request as ready for review April 5, 2024 22:16
@gaukas gaukas requested a review from erikziyunchi as a code owner April 5, 2024 22:16
Copy link
Member

@erikziyunchi erikziyunchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for adding it! I think next time maybe we can put the dependencies change in one commit, and code changes in others?

@gaukas
Copy link
Contributor Author

gaukas commented Apr 8, 2024

... maybe we can put the dependencies change in one commit, and code changes in others?

That's the ideal case. For this repo, since the build relies on replace directive and the old go.mod will not build for the new content in v1 directory, we have to make all changes before any local test would pass.

@gaukas gaukas merged commit 5c9b8ee into master Apr 8, 2024
14 checks passed
@gaukas gaukas deleted the v1 branch July 15, 2024 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants