Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add assign_clade information to documentation #62

Merged
merged 7 commits into from
Nov 19, 2024

Conversation

bsweger
Copy link
Collaborator

@bsweger bsweger commented Nov 19, 2024

Closes #59

This PR consolidates the repo's README and the documentation's User Guide into a single piece of text to keep them in sync. It also adds more information about using the assign_clades method of CladeTime and does some other improvements.

The changes can be reviewed commit by commit.

The goal here is to have one place for user/getting
started information. We'll put it in the README so
it's viewable from GitHub, and will then pull the
README into the sphinx docs.
It's not clear that the Tree object has usefulness outside
of the clade assignment process, so removing it from the
public-facing docs for now.
Add an example to the assign_clades docstring
and document the individual attributes of the
Clade object.
Keep the code example on the landing page very simple and
put the links to the detailed documentation in a more prominent
place.
This changeset also removes an unsed exception
Copy link
Member

@matthewcornell matthewcornell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Looks good to me.

Copy link
Member

@nickreich nickreich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed quickly the documentation pieces of this and it looks good to me as well.

@nickreich nickreich merged commit 8c1bf87 into main Nov 19, 2024
2 checks passed
@nickreich nickreich deleted the bsweger/update-docs/59 branch November 19, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add clade_assignment guide to cladetime docs
3 participants