PutCommentsRequest accepts vec

reinfer · Jul 25, 2024 · 617ade7 · 617ade7
1 parent 671601c
commit 617ade7
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/api/src/lib.rs b/api/src/lib.rs
@@ -490,15 +490,13 @@ impl Client {
     pub fn put_comments_split_on_failure(
         &self,
         source_name: &SourceFullName,
-        comments: &[NewComment],
+        comments: Vec<NewComment>,
         no_charge: bool,
     ) -> Result<SplitableRequestResponse<PutCommentsResponse>> {
         self.splitable_request(
             Method::PUT,
             self.endpoints.put_comments(source_name)?,
-            PutCommentsRequest {
-                comments: comments.to_vec(),
-            },
+            PutCommentsRequest { comments },
             Some(NoChargeQuery { no_charge }),
             Retry::No,
         )

diff --git a/cli/src/commands/create/comments.rs b/cli/src/commands/create/comments.rs
@@ -285,7 +285,11 @@ fn upload_batch_of_comments(
     if !comments_to_put.is_empty() {
         if resume_on_error {
             let result = client
-                .put_comments_split_on_failure(&source.full_name(), comments_to_put, no_charge)
+                .put_comments_split_on_failure(
+                    &source.full_name(),
+                    comments_to_put.to_vec(),
+                    no_charge,
+                )
                 .context("Could not put batch of comments")?;
             failed += result.num_failed;
         } else {