Merge branch 'master' into add-only-with-attachments

reinfer · Aug 5, 2024 · 70b4ea0 · 70b4ea0
2 parents e1f6a53 + 255c5bf
commit 70b4ea0
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,6 @@
 # Unreleased
 - Add `only-with-attachment` filter on get comments
+- Retry when putting comments
 - Add ability to get email by id 
 - Add ability to upload attachment content for comments
 

diff --git a/api/src/lib.rs b/api/src/lib.rs
@@ -522,12 +522,15 @@ impl Client {
         comments: Vec<NewComment>,
         no_charge: bool,
     ) -> Result<SplitableRequestResponse<PutCommentsResponse>> {
+        // Retrying here despite the potential for 409's in order to increase reliability when
+        // working with poor connection
+
         self.splitable_request(
             Method::PUT,
             self.endpoints.put_comments(source_name)?,
             PutCommentsRequest { comments },
             Some(NoChargeQuery { no_charge }),
-            Retry::No,
+            Retry::Yes,
         )
     }
 
@@ -537,12 +540,14 @@ impl Client {
         comments: Vec<NewComment>,
         no_charge: bool,
     ) -> Result<PutCommentsResponse> {
+        // Retrying here despite the potential for 409's in order to increase reliability when
+        // working with poor connection
         self.request(
             &Method::PUT,
             &self.endpoints.put_comments(source_name)?,
             &Some(PutCommentsRequest { comments }),
             &Some(NoChargeQuery { no_charge }),
-            &Retry::No,
+            &Retry::Yes,
         )
     }