fix(api): serde default when missing for property filter (#321)

reinfer · Oct 8, 2024 · c9a783a · c9a783a
1 parent 1ff021b
commit c9a783a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,8 @@
 - Round trip `field_id` 
 - Add `ixp` dataset flag
 - rename label def description to instructions
+- Default value for PropertyValue
+
 
 # v0.33.1
 - Fix selection index issue on custom label trend reports

diff --git a/api/src/resources/comment.rs b/api/src/resources/comment.rs
@@ -72,11 +72,11 @@ pub struct UserPropertiesFilter(pub HashMap<UserPropertyName, PropertyFilter>);
 
 #[derive(Default, Debug, Clone, Serialize, Deserialize)]
 pub struct PropertyFilter {
-    #[serde(skip_serializing_if = "<[_]>::is_empty")]
+    #[serde(skip_serializing_if = "<[_]>::is_empty", default)]
     pub one_of: Vec<PropertyValue>,
-    #[serde(skip_serializing_if = "<[_]>::is_empty")]
+    #[serde(skip_serializing_if = "<[_]>::is_empty", default)]
     pub not_one_of: Vec<PropertyValue>,
-    #[serde(skip_serializing_if = "<[_]>::is_empty")]
+    #[serde(skip_serializing_if = "<[_]>::is_empty", default)]
     pub domain_not_one_of: Vec<PropertyValue>,
     #[serde(skip_serializing_if = "Option::is_none")]
     pub minimum: Option<NotNan<f64>>,