dont clone when splitting

reinfer · Jul 25, 2024 · d25c17f · d25c17f
1 parent 5b9eb2b
commit d25c17f
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 10 deletions.
diff --git a/api/src/lib.rs b/api/src/lib.rs
@@ -144,7 +144,7 @@ pub use crate::{
 pub struct Token(pub String);
 
 pub trait SplittableRequest {
-    fn split(&self) -> Vec<Self>
+    fn split(self) -> Vec<Self>
     where
         Self: Sized;
 

diff --git a/api/src/resources/comment.rs b/api/src/resources/comment.rs
@@ -175,12 +175,11 @@ pub(crate) struct PutCommentsRequest {
 }
 
 impl SplittableRequest for PutCommentsRequest {
-    fn split(&self) -> Vec<Self> {
+    fn split(self) -> Vec<Self> {
         self.comments
-            .clone()
             .into_iter()
             .map(|comment| Self {
-                comments: [comment].to_vec(),
+                comments: vec![comment],
             })
             .collect()
     }
@@ -208,15 +207,14 @@ pub(crate) struct SyncCommentsRequest {
 }
 
 impl SplittableRequest for SyncCommentsRequest {
-    fn split(&self) -> Vec<Self>
+    fn split(self) -> Vec<Self>
     where
         Self: Sized,
     {
         self.comments
-            .clone()
             .into_iter()
             .map(|comment| Self {
-                comments: [comment].to_vec(),
+                comments: vec![comment],
             })
             .collect()
     }

diff --git a/api/src/resources/email.rs b/api/src/resources/email.rs
@@ -56,15 +56,14 @@ pub(crate) struct PutEmailsRequest {
 }
 
 impl SplittableRequest for PutEmailsRequest {
-    fn split(&self) -> Vec<Self>
+    fn split(self) -> Vec<Self>
     where
         Self: Sized,
     {
         self.emails
-            .clone()
             .into_iter()
             .map(|email| Self {
-                emails: [email].to_vec(),
+                emails: vec![email],
             })
             .collect()
     }