commands: add source statistics to table output #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommilligan
approved these changes
Sep 11, 2023
cli/src/commands/get/sources.rs
Outdated
Comment on lines
48
to
62
| sources | ||
| .iter() | ||
| .map(|source| { | ||
| info!("Getting statistics for source {}", source.full_name().0); | ||
| let stats = client | ||
| .get_source_statistics( | ||
| &source.full_name(), | ||
| &StatisticsRequestParams { | ||
| comment_filter: Default::default(), | ||
| }, | ||
| ) | ||
| .expect("Could not get statistics for source"); | ||
| (source.id.clone(), stats) | ||
| }) | ||
| .collect() |
There was a problem hiding this comment.
Should raise error rather than expecting here, as per previous reviews:
Suggested change
| sources | |
| .iter() | |
| .map(|source| { | |
| info!("Getting statistics for source {}", source.full_name().0); | |
| let stats = client | |
| .get_source_statistics( | |
| &source.full_name(), | |
| &StatisticsRequestParams { | |
| comment_filter: Default::default(), | |
| }, | |
| ) | |
| .expect("Could not get statistics for source"); | |
| (source.id.clone(), stats) | |
| }) | |
| .collect() | |
| sources | |
| .iter() | |
| .map(|source| { | |
| info!("Getting statistics for source {}", source.full_name().0); | |
| let stats = client | |
| .get_source_statistics( | |
| &source.full_name(), | |
| &StatisticsRequestParams { | |
| comment_filter: Default::default(), | |
| }, | |
| ) | |
| .context("Could not get statistics for source")?; | |
| Ok((source.id.clone(), stats)) | |
| }) | |
| .collect()? |
or something like this
cli/src/printer.rs
Outdated
| if let Some(stats) = &self.stats { | ||
| stats.num_comments.to_string() | ||
| } else { | ||
| "N/A".to_string() |
There was a problem hiding this comment.
For consistency with above?
Suggested change
| "N/A".to_string() | |
| "none".dimmed() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optionally print
num_commentswhen getting sources