commands: add get dataset stats #231
Conversation
api/src/resources/dataset.rs
Outdated
| @@ -17,7 +17,7 @@ use std::{ | |||
| str::FromStr, | |||
| }; | |||
|
|
|||
| #[derive(Debug, Clone, Deserialize, Serialize, PartialEq, Eq)] | |||
There was a problem hiding this comment.
To avoid having to remove the Eq, you should use ordered_float::NotNan<f64> which we already use for this purpose.
api/src/resources/dataset.rs
Outdated
| @@ -34,6 +34,7 @@ pub struct Dataset { | |||
| pub entity_defs: Vec<EntityDef>, | |||
| pub label_defs: Vec<LabelDef>, | |||
| pub label_groups: Vec<LabelGroup>, | |||
| pub num_reviewed: Option<f64>, | |||
There was a problem hiding this comment.
Do you need something like a #[serde(default)] here, as num_reviewed is not actually returned by the datasets api endpoint?
This is kind of breaking the encapsulation of this type a bit - as it lives in api, I would expect it to map to our api types.
I think it would be better practice to have a struct like
struct DatasetAndStats {
dataset: Dataset,
stats: Option<DatasetStats>
}and you can implement DisplayTable for that instead. Or, just have a type in the cli named Dataset that you can convert From the api Dataset, and add some more stats to.
If you decide not to do the above, I think you need to add a comment documenting that this field is not returned by the datasets api
There was a problem hiding this comment.
Yep, great point. I'll update
joe-prosser
force-pushed
the
datasets-stats
branch
from
c53fae8 to
6cbb78b
Compare
cli/src/printer.rs
Outdated
| impl DisplayTable for DatasetAndStats { | ||
| fn to_table_headers() -> Row { | ||
| row![bFg => "Name", "ID", "Updated (UTC)", "Title", "Num Reviewed"] | ||
| } | ||
|
|
||
| fn to_table_row(&self) -> Row { | ||
| let full_name = format!( | ||
| "{}{}{}", | ||
| self.dataset.owner.0.dimmed(), | ||
| "/".dimmed(), | ||
| self.dataset.name.0 | ||
| ); | ||
| row
Adds flag to get stats for datasets