commands: filter get users by project and permissions #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommilligan
approved these changes
Oct 23, 2023
Comment on lines
+29
to
+31
| if project_name_filter.is_none() && project_permission_filter.is_some() { | ||
| bail!("You cannot filter on `permission` without a `project`") | ||
| } |
There was a problem hiding this comment.
I would argue you could implement this such that if you didn't pass in a project, you got back all users with that permission in any project.
But if that's not the behaviour you want, happy with this.
There was a problem hiding this comment.
Yeah good shout - will save that for a future PR. Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows you to filter
get usersby a project and permissions