Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more stream label validation stats #241

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

joe-prosser
Copy link
Contributor

Adds some additional data for the stream stats. Namely;

  • What precision would you expect if the recall was the same. What threshold do you need for that?
  • What precision would you expect if the precision was the same. What threshold do you need for that?

@joe-prosser joe-prosser self-assigned this Nov 8, 2023
Copy link
Collaborator

@tommilligan tommilligan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one nit on the formatting

Comment on lines 172 to 173
test if test < threshold => format!("{test_str} ({diff:.3})").red(),
test if test > threshold => format!("{test_str} (+{diff:.3})").green(),
Copy link
Collaborator

@tommilligan tommilligan Nov 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use the printf directive + to always add the appropriate sign here:

fn main() {
    for value in [0.0, -0.0, 0.0, -42.3, 42.3] {
        println!("{:+0.3}", value);
    }
}

https://doc.rust-lang.org/std/fmt/#sign0

https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=54b7555880b48aa31f24fd5f3fc499e1

@joe-prosser joe-prosser merged commit 2af59dc into master Nov 8, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants