commands: add get audit events command #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommilligan
approved these changes
Nov 16, 2023
api/src/resources/audit.rs
Outdated
| impl Iterator for QueryResponseIterator { | ||
| type Item = PrintableAuditEvent; | ||
| fn next(&mut self) -> Option<Self::Item> { | ||
| let response = self.response.audit_events.get(self.index).map(|event| { |
There was a problem hiding this comment.
To avoid nesting here, I would return early if you get None like:
Suggested change
| let response = self.response.audit_events.get(self.index).map(|event| { | |
| let response = self.response.audit_events.get(self.index)?; | |
| let actor_email = ... |
api/src/resources/audit.rs
Outdated
Comment on lines
136
to
140
| let actor_email = &self | ||
| .response | ||
| .get_user(&event.actor_user_id) | ||
| .unwrap_or_else(|| panic!("Could not find user for id `{}`", event.actor_user_id.0)) | ||
| .email; |
There was a problem hiding this comment.
If perf is ever an issue here, I would suggest converting the raw response into some hashmap lookups for users/datasets etc. at the point you convert it to QueryResponseIterator, so you're not repeatedly scanning with find.
But happy this works.
Note that I think it is technically possible for us to not return all linked resources (e.g. if the user has been deleted, won't be included).
I'm happy for your cases this is not likely, but if you were pushing this out to other users, I'd want some nicer error handling here.
joe-prosser
force-pushed
the
get-audit-events
branch
from
3900092 to
f52b634
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a command to return audit events