Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): remove required and type from moon label def #249

Merged
merged 2 commits into from
Jan 18, 2024
Merged

fix(api): remove required and type from moon label def #249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13e57ae
fix(api): remove required and type from moon label def
joe-prosser Jan 17, 2024
e2f0b76
fix clippy
joe-prosser Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions api/src/resources/label_def.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,4 @@ pub struct NewLabelDefPretrained {
pub struct MoonFormFieldDef {
pub name: String,
pub kind: String,
pub required: bool,
#[serde(rename = "type")]
pub field_type: String,
}
4 changes: 2 additions & 2 deletions cli/tests/test_comments.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ fn check_comments_lifecycle(comments_str: &str, args: Vec<&str>) {
}

// Test getting a comment by id to check the content matches
let test_comment = annotated_comments.get(0).unwrap().comment.clone();
let test_comment = annotated_comments.first().unwrap().comment.clone();
let output = cli.run([
"get",
"comment",
Expand All @@ -111,7 +111,7 @@ fn check_comments_lifecycle(comments_str: &str, args: Vec<&str>) {
"delete",
"comments",
&format!("--source={}", source.identifier()),
&annotated_comments.get(0).unwrap().comment.id.0,
&annotated_comments.first().unwrap().comment.id.0,
]);
assert!(output.is_empty());

Expand Down
4 changes: 0 additions & 4 deletions cli/tests/test_datasets.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,8 +242,6 @@ fn test_create_update_dataset_custom() {
moon_form: Some(vec![MoonFormFieldDef {
name: "luna".to_owned(),
kind: "ent".to_owned(),
required: false,
field_type: "string".to_owned(),
}]),
},
],
Expand All @@ -270,8 +268,6 @@ fn test_create_update_dataset_custom() {
moon_form: Some(vec![MoonFormFieldDef {
name: "luna".to_owned(),
kind: "ent".to_owned(),
required: false,
field_type: "string".to_owned(),
}]),
},
],
Expand Down
Loading