Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): fix fetch & advance stream requests #251

Merged
merged 1 commit into from
Jan 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# unreleaswed
- Fix a bug where stream responses were not correctly parsed
- Fix a bug where streams were not correctly advanced

# v0.21.4
- Add messages filters
- Fixes `required` field error when interacting with datasets
Expand Down
1 change: 1 addition & 0 deletions api/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1439,6 +1439,7 @@ impl Endpoints {
&stream_name.dataset.0,
"streams",
&stream_name.stream.0,
"advance",
],
)
}
Expand Down
2 changes: 1 addition & 1 deletion api/src/resources/comment.rs
Original file line number Diff line number Diff line change
Expand Up @@ -624,7 +624,7 @@ pub struct Label {

#[derive(Debug, Clone, Deserialize, Serialize, PartialEq, Eq)]
pub struct PredictedLabel {
pub name: LabelName,
pub name: Vec<String>,
#[serde(skip_serializing_if = "Option::is_none")]
pub sentiment: Option<NotNan<f64>>,
pub probability: NotNan<f64>,
Expand Down
2 changes: 1 addition & 1 deletion cli/src/commands/get/comments.rs
Original file line number Diff line number Diff line change
Expand Up @@ -613,7 +613,7 @@ fn get_comments_from_uids(
auto_threshold_labels
.iter()
.map(|auto_threshold_label| PredictedLabel {
name: LabelName(auto_threshold_label.name.join(" > ")),
name: auto_threshold_label.name.to_owned(),
sentiment: None,
probability: auto_threshold_label.probability,
auto_thresholds: Some(
Expand Down
Loading