feat(cli): add feature to make context a required field #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tommilligan
approved these changes
Apr 4, 2024
| Ok(client) | ||
| } | ||
|
|
||
| const DOMAINS_THAT_REQUIRE_CONTEXT: [&str; 2] = ["uipath.com", "reinfer.io"]; |
There was a problem hiding this comment.
I would vote let's make it required for everyone until they opt out by setting the config flag honestly, I agree with you about the bad implications of uploading to the wrong place. I think quite common for even client orgs to have a staging and prod tenant right?
There was a problem hiding this comment.
Yeah ok cool - did worry about that breaking any existing scripts that people have. But maybe forcing them to opt out isn't a bad thing
CHANGELOG.md
Outdated
Comment on lines
1
to
4
| # Unreleased | ||
| - Add option to make context option a required field | ||
| - Make context option a required field for internal users | ||
|
|
There was a problem hiding this comment.
You should note explicitly that this is a breaking change for reinfer/uipath users.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the
re -c <context>required if you're a UiPath user / if you opt for that in the config