Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(commands): reduce batch size when bulk deleting comments #270

Merged
merged 1 commit into from
Apr 23, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Unreleased
- Fixes issue when getting streams that have multiple filters on single user property
- Fixes issue where upper case file names would not be matched in `parse`
- Reduce batch size when deleting comment batches

# v0.24.0
- BREAKING: the `--context` option is now required. Users need to opt
Expand Down
2 changes: 1 addition & 1 deletion cli/src/commands/delete.rs
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ fn delete_comments_in_period(
};

// This is the maximum number of comments which the API permits deleting in a single call.
const DELETION_BATCH_SIZE: usize = 128;
const DELETION_BATCH_SIZE: usize = 32;
// Buffer to store comment IDs to delete - allow it to be slightly larger than the deletion
// batch size so that if there's an incomplete page it'll increase the counts.
let mut comments_to_delete =
Expand Down
Loading