feat(commands): add lossy flag when creating annotations #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan-ri
reviewed
Jul 24, 2024
|
|
||
| #[structopt(long)] | ||
| /// Whether to attempt to resume processing on error | ||
| lossy: bool, |
There was a problem hiding this comment.
lossy isn't very descriptive. How about resume-on-error?
Comment on lines
379
to
388
| format!( | ||
| "{} {}{}", | ||
| num_annotations, | ||
| "annotations".dimmed(), | ||
| if num_failed_annotations > 0 { | ||
| format!(" {} {}", num_failed_annotations, "skipped".dimmed()) | ||
| } else { | ||
| "".to_string() | ||
| } | ||
| ), |
There was a problem hiding this comment.
The nested format! is a bit cheeky. How about:
let failed_annotations_string = if num_failed_annotations > 0 {
format!(" {num_failed_annotations} {}", "skipped".dimmed())
} else {
String::new()
};Similarly below.
cli/src/main.rs
Outdated
Comment on lines
206
to
218
| pub fn print_error_as_warning(error: &anyhow::Error) { | ||
| warn!("An error occurred. Resuming..."); | ||
| for cause in error.chain() { | ||
| warn!(" |- {}", cause); | ||
| } | ||
| } | ||
|
|
||
| pub fn print_error(error: &anyhow::Error) { | ||
| error!("An error occurred:"); | ||
| for cause in error.chain() { | ||
| error!(" |- {}", cause); | ||
| } | ||
| } |
There was a problem hiding this comment.
We shouldn't need two functions. How about just
pub fn print_error(error: &anyhow::Error) {
for cause in error.chain() {
error!(" |- {}", cause);
}
}and leave the call to error!()before it in main() below. You can add the call to warn!() in upload_batch_of_annotations(), but I'm not sure logging in that case is necessary.
dan-ri
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a flag to attempt to resume processing when operations fail. Starting with annotations but could later be used for comments also