chore(api): round trip field id #320
Conversation
| #[derive(Debug, Clone, PartialEq, Deserialize, Serialize, Eq)] | ||
| pub struct NewEntityWithSpans { | ||
| pub name: EntityName, | ||
| pub formatted_value: String, | ||
| pub field_id: FieldId, |
There was a problem hiding this comment.
We should also add it to NewEntityWithSpan for the legacy cases no? And what about the non-new one, like Entity? actually I see that Entity doesn't support the legacy span case either...
There was a problem hiding this comment.
Entity doesn't support the legacy span case either...
I think I'll address this in a separate PR
We should also add it to NewEntityWithSpan for the legacy cases no?
Yep, good spot!
There was a problem hiding this comment.
I think I'll address this in a separate PR
yeah that's totally fair, it's just a bit sad to see the state we left the cli in 😬 thanks for cleaning up the mess
| #[derive(Debug, Clone, PartialEq, Deserialize, Serialize, Eq)] | ||
| pub struct NewEntityWithSpans { | ||
| pub name: EntityName, | ||
| pub formatted_value: String, | ||
| pub field_id: FieldId, |
There was a problem hiding this comment.
I think I'll address this in a separate PR
yeah that's totally fair, it's just a bit sad to see the state we left the cli in 😬 thanks for cleaning up the mess
No description provided.